Ludovic Courtès writes: Hi! > Starting a dive through this amazing patch series… Yay, and thanks again for your careful review. >> + (source >> + (bootstrap-origin > > You can remove the ‘bootstrap-origin’ call: it’s only useful when there > are patches or snippets. Ah, right. Removed. >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://lilypond.org/janneke/guix/20220501/" >> + "bootstrap-seeds-" version ".tar.gz")) > > You can add a mirror://gnu/guix/mirror URL and we’ll copy it to > ftp.gnu.org. Changed to: (uri (list (string-append "mirror://gnu/guix/mirror/" "bootstrap-seeds-" version ".tar.gz") (string-append "https://lilypond.org/janneke/guix/20220501/" "bootstrap-seeds-" version ".tar.gz"))) >> + (native-inputs `(("bootar" ,bootar))) > > -> (list boottar) Ok. >> + (build-system trivial-build-system) >> + (arguments >> + `(#:guile ,%bootstrap-guile >> + #:modules ((guix build utils)) >> + #:builder >> + (begin >> + (use-modules (guix build utils)) >> + (let ((source (assoc-ref %build-inputs "source")) >> + (tar (assoc-ref %build-inputs "bootar")) >> + (out (assoc-ref %outputs "out"))) > > You can make it a gexp like so: > > (arguments > (list #:guile … > #:builder > #~(begin Ok. >> + #t)))) > > You can remove the trailing #t. Ok. >> + (description >> + "A prebuilt version of the initial bootstrap seeds. It contains a > > The first thing could be a sentence, say: “This package provides > pre-built binaries of the bootstrap seeds.” >> +hex0-seed and an optional kaem-minimal shell. The size of the hex0 seeds are >> +for knight: 250 bytes, x86-linux:(357 bytes, x86_64-linux: 431 bytes, and > ^ > Extra paren. Removed. Greetings, Janneke -- Jan Nieuwenhuizen | GNU LilyPond https://lilypond.org Freelance IT https://JoyOfSource.com | Avatar® https://AvatarAcademy.com