From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 15:19:43 2022 Received: (at 54786) by debbugs.gnu.org; 28 Apr 2022 19:19:43 +0000 Received: from localhost ([127.0.0.1]:49980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk9fy-0004dd-PG for submit@debbugs.gnu.org; Thu, 28 Apr 2022 15:19:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk9fx-0004dQ-34 for 54786@debbugs.gnu.org; Thu, 28 Apr 2022 15:19:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk9fr-0005IG-T4 for 54786@debbugs.gnu.org; Thu, 28 Apr 2022 15:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=XUtZBeT1Nw+P+JFOnzr8udHM7kNZFiS+Bf3OO9Qx4P0=; b=qCGRk9eVcB33RbvfOc5L 01JnZmhF6Yj73con5ghWUZawROdwSiHgjH1uFvzNPqdvkqiK5s8toqkcC6sNWIA4phfw/yrBEis0Y s5wNczm7rs0to7HbeNg30SRy1srDXkLQM4lCx/PfB+/d7odHg/S25+ZYxZk6bWHXdjzJLiYR5gcEW 4MM3G90HV05ZFv6mQYvXcrcx0fYGjYPDgAuiXjdBOtGXPQHOf3ED3UwZhEFasTSFQUB1JBfynAte/ ObkzkV7v8vJa71bLFuhEUzZM59O4FrEm49Bs3Ljzz9yKHRb/SSy2x590Tm53Uafm+ZeUoN889ccj7 CsBPhqkpc3iI2g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52340 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk9fr-0006bi-GK; Thu, 28 Apr 2022 15:19:35 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#54786: Installation tests are failing References: <87r167rjhv.fsf@gnu.org> <87v8vjwqzk.fsf@gnu.org> <87zgk5brkd.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Apr 2022 21:19:33 +0200 In-Reply-To: <87zgk5brkd.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 28 Apr 2022 09:22:26 +0200") Message-ID: <87y1zpaud6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54786 Cc: 54786@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Mathieu Othacehe skribis: >> * cgit-test (https://ci.guix.gnu.org/build/646812/details) > > The nginx daemon seems to be started multiple times: I believe this is caused by a change of semantics (really: a bug) in the shepherd =E2=80=98start=E2=80=99 method in 0.9.0. Previously, =E2=80=98start=E2=80=99 would wait until the daemon was started= . If the service was being started, shepherd wouldn=E2=80=99t reply until it was done starting it. In 0.9.0, shepherd replies even while it=E2=80=99s waiting for the service = to be started. But as a consequence, it lets you start a service that is already being started, leading to this mess you reported. The proper fix is to better track the status of each service in shepherd, and to prevent double-starts. In the interim, perhaps we can work around that by using a different check to determine whether the service is running. For instance, instead of: (test-assert "nginx running" (marionette-eval '(begin (use-modules (gnu services herd)) (start-service 'nginx)) marionette)) =E2=80=A6 we=E2=80=99d write something like: (test-assert "nginx running" (wait-for-file "/var/run/nginx/pid")) Thoughts? I=E2=80=99ll give that a try. Thanks for the heads-up! Ludo=E2=80=99.