From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 12 14:22:05 2022 Received: (at 53005) by debbugs.gnu.org; 12 Jan 2022 19:22:05 +0000 Received: from localhost ([127.0.0.1]:59148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jC9-0003nK-Gq for submit@debbugs.gnu.org; Wed, 12 Jan 2022 14:22:05 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:44229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jC7-0003mo-TE for 53005@debbugs.gnu.org; Wed, 12 Jan 2022 14:22:04 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 0E0AE3200F76; Wed, 12 Jan 2022 14:21:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 12 Jan 2022 14:21:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=4iZn2xMMOw1pkvR1WI3MyJhR rYTAjT4ogJA227BMG6o=; b=hL3jy6FC7eF+wwq5iGF91sG0tzGfvtN2HXdgf9kV bK5aRu0wbizMkhnX1ySgl/x0oJv1QaFKSFSCpgux1CFxJDV9f25CC8T90PcBS/Dy JEeyEFKi5tMkQaGcvNXp025n3WoahepI8GZ9e68OFsZb3rYa3R1u1N/dok9VYksO 7co= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=4iZn2x MMOw1pkvR1WI3MyJhRrYTAjT4ogJA227BMG6o=; b=gkCFY3cU6qaaPjWxh3y8N4 QpMSnvJHcJrIemGHj9fWfdESrhKR5t8TdY1LWLXzoTh4frI+taewwF+M3RA6CDKR lPhPaCcRhswJwZWDezJiixYYX857j6AHTRlAf/EkEMSFzSCpn8mXLTxFyh0deWOj xai+5ip2iCLNhStqlKCdV62VHe1kDZef2vhY19PGO7mmoP4IQnMrfK/mcViv9RJ7 yT8Oo2CeRcBwWwfVnicp8KLLuvO9ue3v0yct40aYsz4O4RW5fjQOO+s5s7NiZl6i Wk36aOtYgFT3MaDzOImUeG4Wbw97ljCee8yata7m6sj6grpvTCGWLmeEJF4QkkMQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtddugdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvg hrnhepvddvudegffefiedttdfhfedvuefhgfekieekgeekveetgefhfeetgfegueduffei necuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jan 2022 14:21:57 -0500 (EST) Date: Wed, 12 Jan 2022 14:21:55 -0500 From: Leo Famulari To: Simon South Subject: Re: bug#53005: [PATCH 1/1] gnu: glibc: Preserve "__pthread_key_create" symbol. Message-ID: References: <7e85b4a230a68240759120e8440ea77cf1d6e927.1641856285.git.simon@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e85b4a230a68240759120e8440ea77cf1d6e927.1641856285.git.simon@simonsouth.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53005 Cc: 53005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Jan 10, 2022 at 06:34:26PM -0500, Simon South wrote: > Avoid a potential crash in multithreaded applications by preserving the > pthread library's "__pthread_key_create" symbol, used by libgcc to detect the > use of threads in an application. > > Fixes . > > * gnu/packages/base.scm (glibc)[arguments]: Add "#:strip-flags" with > "--keep-symbol=__pthread_key_create" appended to the default set. Thanks for analysing this bug and sending a patch. Because the proposed fix changes glibc, it will require rebuilding the entire distro. That's expensive, so, we need to think about it some more before deciding what to do. First, how was the LUKS2 volume created? Was it created by Guix System? Is it the default type of LUKS volume created by Guix? I see that our cryptsetup package has "with-default-luks-format=LUKS1". I'm trying to understand how many users will be affected by this bug. Second, do other distros have to apply the same workaround with '--keep-symbol'? Like, is this problem widespread? Is Guix doing something wrong that requires the workaround? Sorry if you already answered these questions in your previous messages.