[PATCH] services: dhcp-client-service-type: Support DDNS.

  • Done
  • quality assurance status badge
Details
2 participants
  • Lilah Tascheter
  • Ludovic Courtès
Owner
unassigned
Submitted by
Lilah Tascheter
Severity
normal
L
L
Lilah Tascheter wrote on 5 Jul 2023 02:10
(address . guix-patches@gnu.org)(name . Lilah Tascheter)(address . lilah@lunabee.space)
82fd5037dd1ec543b4df97995bb55d61f5165334.1688515814.git.lilah@lunabee.space
* gnu/services/networking.scm (dhcp-client-shepherd-service): Enable -I
flag on dhclient.
---
gnu/services/networking.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 5657b141d9..0fbba1b8c7 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -350,7 +350,7 @@ (define ifaces
(false-if-exception (delete-file #$pid-file))
(let ((pid (fork+exec-command
- (cons* dhclient "-nw"
+ (cons* dhclient "-nw" "-I"
"-pf" #$pid-file ifaces))))
(and (zero? (cdr (waitpid pid)))
(read-pid-file #$pid-file)))))

base-commit: 9122736455a9085d51b71b269b7c26a695a474ef
--
2.40.1
L
L
Ludovic Courtès wrote on 11 Oct 2023 19:14
(name . Lilah Tascheter)(address . lilah@lunabee.space)(address . 64468@debbugs.gnu.org)
8734yht735.fsf@gnu.org
Hi,

Lilah Tascheter <lilah@lunabee.space> skribis:

Toggle quote (3 lines)
> * gnu/services/networking.scm (dhcp-client-shepherd-service): Enable -I
> flag on dhclient.

[...]

Toggle quote (2 lines)
> + (cons* dhclient "-nw" "-I"

Could there be unintended side effects from passing “-I”? The
dhclient(8) man page is silent about the implications.

If there are none, the patch LGTM.

Thanks,
Ludo’.
L
L
Ludovic Courtès wrote on 11 Oct 2023 19:14
control message for bug #64468
(address . control@debbugs.gnu.org)
871qe1t72x.fsf@gnu.org
tags 64468 + moreinfo
quit
L
L
Lilah Tascheter wrote on 12 Oct 2023 22:23
Re: [bug#64468] [PATCH] services: dhcp-client-service-type: Support DDNS.
(name . Ludovic Courtès)(address . ludo@gnu.org)
20231012152349.2f23108b@lunabee.space
Ludovic Courtès <ludo@gnu.org> wrote:
Toggle quote (2 lines)
> Could there be unintended side effects from passing "-I"?

the isc-dhcp knowledgebase says that by default dhclient uses a
pre-standardization implementation of DDNS, which is incompatable with non-isc
DHCP servers. no idea why that's the default, but -I just switches to using the
standardized protocol.

kb link with more details: https://kb.isc.org/docs/aa-01091

~lunabee
L
L
Ludovic Courtès wrote on 14 Oct 2023 19:45
(name . Lilah Tascheter)(address . lilah@lunabee.space)(address . 64468-done@debbugs.gnu.org)
87fs2dcd3s.fsf@gnu.org
Lilah Tascheter <lilah@lunabee.space> skribis:

Toggle quote (10 lines)
> Ludovic Courtès <ludo@gnu.org> wrote:
>> Could there be unintended side effects from passing "-I"?
>
> the isc-dhcp knowledgebase says that by default dhclient uses a
> pre-standardization implementation of DDNS, which is incompatable with non-isc
> DHCP servers. no idea why that's the default, but -I just switches to using the
> standardized protocol.
>
> kb link with more details: https://kb.isc.org/docs/aa-01091

Thanks for explaining. I added this explanation as a comment in the
code and committed.

Ludo’.
Closed
?