[PATCH] gnu: emacs-geiser: Update to 0.23.1.

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Olivier Dion
Owner
unassigned
Submitted by
Olivier Dion
Severity
normal
O
O
Olivier Dion wrote on 27 Mar 2022 00:11
(address . guix-patches@gnu.org)(name . Olivier Dion)(address . olivier.dion@polymtl.ca)
9a60062f0fe04694a063d7d872a1963e9069598a.1648336239.git.olivier.dion@polymtl.ca
* gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
[propagated-inputs]: Add emacs-project.
---
gnu/packages/emacs-xyz.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 42fc13f4c2..57a2f574c5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -271,7 +271,7 @@ (define-public emacs-geiser
(native-inputs
(list texinfo))
(propagated-inputs
- (list emacs-transient))
+ (list emacs-project emacs-transient))
(home-page "https://nongnu.org/geiser/")
(synopsis "Collection of Emacs modes for Scheme hacking")
(description
--
2.34.0
L
L
Ludovic Courtès wrote on 29 Mar 2022 11:29
(name . Olivier Dion)(address . olivier.dion@polymtl.ca)(address . 54589@debbugs.gnu.org)
87fsn13y42.fsf@gnu.org
Hi,

Olivier Dion <olivier.dion@polymtl.ca> skribis:

Toggle quote (3 lines)
> * gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
> [propagated-inputs]: Add emacs-project.

I suppose the emacs-geiser-* packages should be updated at the same
time, shouldn’t they?

Could you send an updated patch that does that too?

Thanks,
Ludo’.
L
L
Ludovic Courtès wrote on 4 Apr 2022 22:45
control message for bug #54589
(address . control@debbugs.gnu.org)
878rskshku.fsf@gnu.org
tags 54589 + moreinfo
quit
O
O
Olivier Dion wrote on 6 Apr 2022 03:16
Re: bug#54589: [PATCH] gnu: emacs-geiser: Update to 0.23.1.
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 54589@debbugs.gnu.org)
87bkxfvwnj.fsf@laura
On Tue, 29 Mar 2022, Ludovic Courtès <ludo@gnu.org> wrote:
Toggle quote (2 lines)
> Hi,

Sorry for the long delay.

Toggle quote (8 lines)
> Olivier Dion <olivier.dion@polymtl.ca> skribis:
>
>> * gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
>> [propagated-inputs]: Add emacs-project.
>
> I suppose the emacs-geiser-* packages should be updated at the same
> time, shouldn’t they?

I don't think so? Emacs geiser is already bumped at version 0.23.1, but
the commit that introduced that change forgot to add the new dependency
`emacs-project`.

I think that the commit message is confusing, sorry for that. It should
probably be `Add missing dependency ` and not `Update to ...`. Let me
know what you think.

--
Olivier Dion
oldiob.dev
L
L
Ludovic Courtès wrote on 8 Apr 2022 23:09
(name . Olivier Dion)(address . olivier.dion@polymtl.ca)(address . 54589-done@debbugs.gnu.org)
87y20f9t9w.fsf_-_@gnu.org
Hi,

Olivier Dion <olivier.dion@polymtl.ca> skribis:

Toggle quote (8 lines)
> I don't think so? Emacs geiser is already bumped at version 0.23.1, but
> the commit that introduced that change forgot to add the new dependency
> `emacs-project`.
>
> I think that the commit message is confusing, sorry for that. It should
> probably be `Add missing dependency ` and not `Update to ...`. Let me
> know what you think.

Indeed, I had overlooked that. Committed with the commit message
adjusted accordingly.

Thanks,
Ludo’.
Closed
?