cc-for-target makes --with-c-toolchain unusable for some packages

OpenSubmitted by raingloom.
Details
3 participants
  • Ludovic Courtès
  • Maxime Devos
  • raingloom
Owner
unassigned
Severity
important
R
R
raingloom wrote on 8 Apr 2021 02:33
(name . Guix Bugs)(address . bug-guix@gnu.org)
20210408023329.4e6d48d7@riseup.net
I tried compiling lua with clang on a whim and found out about
cc-for-target. Not sure if that's the only instance of hardcoded gcc,
but it's certainly a prominent one.

What would be the idiomatic way to fix it? Detect clang dynamically? Or
move cc-for-target inside the build system module and make it available
at build time?
M
M
Maxime Devos wrote on 12 Apr 2021 11:47
0139952bd05c10e068ce564d7982a90b032d9874.camel@telenet.be
On Thu, 2021-04-08 at 02:33 +0200, raingloom wrote:
Toggle quote (4 lines)
> I tried compiling lua with clang on a whim and found out about
> cc-for-target. Not sure if that's the only instance of hardcoded gcc,
> but it's certainly a prominent one.

A little more information:
this is not specific to cc-for-target. Try searching for "CC=gcc".

Most uses of "CC=gcc" are incorrect when cross-compiling. When
cross-compiling, these should be "CC=ARCHITECTURE-linux-gnu-gcc" or
something like that. The "cc-for-target" procedure outputs the correct
string.

Toggle quote (4 lines)
> What would be the idiomatic way to fix it? Detect clang dynamically? Or
> move cc-for-target inside the build system module and make it available
> at build time?

To avoid massive rebuilds, perhaps the procedure "cc-for-target" could be
replaced with a macro "cc-for-target" that accesses the native-inputs of
this-package to determine whether it should output "CC=gcc" /
"CC=ARCHITECTURE-linux-gnu-gcc" or "CC=clang" / "CC=ARCHITECTURE-linux-gnu-clang"?

Also, moving cc-for-taget to the build system module would require changing
existing package definitions:
,(string-append "CC=" (cc-for-target)) --> (string-append "CC=" (cc-for-target))
(string-append "CC=" ,(cc-for-target)) --> (string-append "CC=" (cc-for-targt))

Warning: I haven't tested whether this approach works with --with-c-toolchain.

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHQXMxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7s68AQDlXiFzoni85L2OIBV6pvSinJsn
asEjNqbqtXvBGsLVZQEA5rFY5J7LfSVK+abmzqU+lJ7LBi23hso42y6C/JTLSAM=
=CghC
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 16 Apr 2021 17:44
control message for bug #47648
(address . control@debbugs.gnu.org)
87fszq44kz.fsf@gnu.org
severity 47648 important
quit
?